Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Aarón to About Us #41736

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Apr 1, 2024

@aarongarciah aarongarciah added the website Pages that are not documentation-related, marketing-focused. label Apr 1, 2024
@mui-bot
Copy link

mui-bot commented Apr 1, 2024

Netlify deploy preview

https://deploy-preview-41736--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c9ee98a

@danilo-leal danilo-leal changed the base branch from master to next April 1, 2024 17:16
@danilo-leal danilo-leal force-pushed the aaron/about branch 2 times, most recently from 8da0974 to 68c9343 Compare April 1, 2024 17:56
@danilo-leal danilo-leal changed the base branch from next to master April 1, 2024 18:15
@danilo-leal danilo-leal changed the base branch from master to next April 1, 2024 18:16
@aarongarciah aarongarciah changed the base branch from next to master April 1, 2024 18:33
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 1, 2024

I think that it would be great to adopt what @MBilalShafi introduced in MUI X: mui/mui-x#11382, the latest version of it. They used it a lot, 160 times exactly.

This GitHub Actions makes it easy to cherry-pick changes from the working branch (next) to the stable branch (master). Examples of how it works: https://github.com/mui/mui-x/pulls?q=is%3Apr+%22%5BDataGrid%5D+Fix+ElementType+usage%22+is%3Aclosed+.

Step 1

SCR-20240401-sjvl

Step 2

SCR-20240401-skhn

cc @mnajdova

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Welcome! And sorry for the bit of mess there when switching the base branch 🙈

@aarongarciah aarongarciah merged commit 5e4fb9c into mui:next Apr 1, 2024
19 checks passed
@aarongarciah aarongarciah added needs cherry-pick The PR should be cherry-picked to master after merge and removed needs cherry-pick The PR should be cherry-picked to master after merge labels Apr 2, 2024
@aarongarciah aarongarciah deleted the aaron/about branch April 2, 2024 14:21
aarongarciah added a commit to aarongarciah/material-ui that referenced this pull request Apr 2, 2024
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants